metabase / metabase/toucan

Should atoms in toucan.hydrate flushed after defmodel?

Open
#34 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Clojure
Stars
576
Forks
48
PR merge metrics
No merged PRs in 30d

Description

When we change models, we may change `hydration-keys`, this change will not work unless we reload `toucan.hydrate` namespace. This looks inconvenient in development.

Since `automagic-batched-hydration-key->model` and `automagic-batched-hydration-keys` are delays, why not reload them after each time we call `defmodel`? maybe there's a better way for this?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the toucan.hydrate namespace and the defmodel path, focusing on automagic-batched-hydration-key->model and automagic-batched-hydration-keys. Trace how hydration-keys changes are handled after defmodel; done means model changes work without manually reloading toucan.hydrate, or the repository documents a better approach.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
backend, database
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.