metabase / metabase/metabase

Support monotone brand colors on the SDK

Open
#65,915 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

.Auto triaged .Team/Embedding Type:New Feature
Dominant language
Clojure
Stars
49.3k
Forks
6.8k
Avg merge
1d 13h
Merged PRs (30d)
653

Description

Is your feature request related to a problem? Please describe.
If I want to use a monotono color scheme. i.e Brand Color is Black/White based on the theme. The SDK doesn't work well when th brand and text-primary are set to the same color. In the buttons we have the text, which is text primary, and then the background color of the button is based off the brand color. This works fine if brand and text-primary color are different, but if they are the same color it doesn't.

So I expect the foreground color on buttons (black on white) to be different than foreground on background (white on black)

Image Image

Describe the solution you'd like
Support this type of color system, so shifting text color in a way that guarantees better contrast.

Describe alternatives you've considered
None since the foregrounds (checkbox's check mark and the button's text color) are hard-coded, and are different than the text-primary color (which I set to white because my app is dark mode)

Additional context

There is more context here https://metaboat.slack.com/archives/C06FCQT0KMZ/p1763384940043469?thread_ts=1763379377.871829&cid=C06FCQT0KMZ

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the SDK button and checkbox foreground-color handling described in the issue, then trace how brand and text-primary theme values reach those controls. Done means monotone brand themes produce distinct, readable foreground colors for buttons and checkbox marks, with coverage for both light and dark cases.

Written by the indexing model from the issue text.

Assessment

Domain
accessibility, design, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.