Search page isn't accessible from the Search Menu Unless there are Results
- Dominant language
- Clojure
- Stars
- 49.3k
- Forks
- 6.8k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 653
Description
### Describe the bug
If you search for an item you can navigate to the search page using the "View and filter all XX results" options. If there are no results there is no navigation to this page.
This is problematic if you want to search the Trash for items that aren't coming up in the search bar, for example. You can't toggle that filter on unless you first search for a term that returns records to get to the search page. Then run the search again with your toggles applied.
### To Reproduce
1. Save a question named "eeeeeee"
2. Drop it in the trash
3. Try to search for it form the search bar
You can't find it and you can't navigate to the search page in order to search the Trash.
### Expected behavior
Search page should be accessible somehow
### Logs
_No response_
### Information about your Metabase installation
```JSON
{
"browser-info": {
"language": "en-US",
"platform": "Win32",
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36",
"vendor": "Google Inc."
},
"metabase-info": {
"databases": [
"h2",
"postgres",
"snowflake"
],
"run-mode": "prod",
"plan-alias": "enterprise-self-hosted",
"version": {
"date": "2024-12-03",
"tag": "v1.51.6.5",
"hash": "22b76e9"
},
"settings": {
"report-timezone": null
},
"hosting-env": "unknown",
"application-database": "postgres",
"application-database-details": {
"database": {
"name": "PostgreSQL",
"version": "15.1 (Debian 15.1-1.pgdg110+1)"
},
"jdbc-driver": {
"name": "PostgreSQL JDBC Driver",
"version": "42.7.3"
}
}
},
"system-info": {
"file.encoding": "UTF-8",
"java.runtime.name": "OpenJDK Runtime Environment",
"java.runtime.version": "11.0.25+9",
"java.vendor": "Eclipse Adoptium",
"java.vendor.url": "https://adoptium.net/",
"java.version": "11.0.25",
"java.vm.name": "OpenJDK 64-Bit Server VM",
"java.vm.version": "11.0.25+9",
"os.name": "Linux",
"os.version": "5.15.167.4-microsoft-standard-WSL2",
"user.language": "en",
"user.timezone": "GMT"
}
}
```
### Severity
annoying
### Additional context
Yo u an work around it by searching for an item that does exist in order to get to the page. You can also navigate directly to the search URL if you know how to.
Contributor guide
Research direction
Start by reproducing the search-bar flow with an item that has been moved to Trash, then compare it with a search that returns results and exposes the full search page. Trace the search menu and no-results state; done means the search page remains reachable when no results are found and its existing filters can be used.
Written by the indexing model from the issue text.
Assessment
- Domain
- frontend, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100