The login from new device notification does't always matches the Device location.
- Dominant language
- Clojure
- Stars
- 49.3k
- Forks
- 6.8k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 653
Description
### Describe the bug
We have occasions when there is a new login from a new device the location doesn't match the actual location of the user. For example a user in Oklahoma got the location of Texas
Another user which lives in Texas got the following notification his location was in Miami Florida
### To Reproduce
No idea how to properly reproduce this. Tried to test with a VPN but didn't manage to replicate but there is something wrong with our location.
The users I mentioned above had his IDP logs IP correctly pointing to Texas where the user lives. Only Metabase notification was wrong.
I am not sure how to consistently replicate.
### Expected behavior
The Device location matches the notification
### Logs
None that are relevant
### Information about your Metabase installation
```JSON
Happened both in stats and in a version 50
```
### Severity
Depends how important is security.
### Additional context
_No response_
Contributor guide
Research direction
No files or tests are named. Start by tracing the new-device login notification and its location lookup, then compare the notification result with the correctly geolocated IDP IPs described in the report. Done means the device location in the notification matches the expected login location, with the behavior verified for the reported cases.
Written by the indexing model from the issue text.
Assessment
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100