metabase / metabase/metabase

`AdminEmbedMenu` console error

Open
#46,990 0 comments 0 reactions 0 assignees View on GitHub
.DX .Frontend .Team/AdminWebapp Type:Tech Debt
Dominant language
Clojure
Stars
49.3k
Forks
6.8k
Avg merge
1d 13h
Merged PRs (30d)
653

Description

```
console.js:13 Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `@mantine/core/PopoverTarget`.
at ViewFooterSharingButton (http://localhost:8080/app/dist/app-main.hot.bundle.js:580151:99)
at http://localhost:8080/app/dist/vendor.hot.bundle.js:24539:87
at http://localhost:8080/app/dist/vendor.hot.bundle.js:21084:87
at Provider (http://localhost:8080/app/dist/vendor.hot.bundle.js:39951:23)
at Popover (http://localhost:8080/app/dist/vendor.hot.bundle.js:24134:65)
at Provider (http://localhost:8080/app/dist/vendor.hot.bundle.js:39951:23)
at Menu (http://localhost:8080/app/dist/vendor.hot.bundle.js:20410:87)
at Menu
at AdminEmbedMenu (http://localhost:8080/app/dist/app-main.hot.bundle.js:465500:11)
at EmbedMenu (http://localhost:8080/app/dist/app-main.hot.bundle.js:465750:84)
```

Contributor guide

Open the contributing guide

Research direction

Locate AdminEmbedMenu and ViewFooterSharingButton, then inspect how the latter is passed to Mantine's PopoverTarget. Reproduce the console warning in the embed menu and trace the ref usage. Done means the warning no longer appears and the menu still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.