metabase / metabase/metabase

Improved Error Handling for Map Viz

Open
#41,796 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Type:New Feature Visualization/Maps
Dominant language
Clojure
Stars
49.3k
Forks
6.8k
Avg merge
1d 13h
Merged PRs (30d)
653

Description

**Is your feature request related to a problem? Please describe.**
Given a list of countries plotted on a map, sometimes a country will not show up on the map because the code has a leading or trailing whitespace in it. We could also consider the case where there is a 2 digit code that doesn't correspond to a country code.

**Describe the solution you'd like**
I could think of a few options for handling this:

- Implementing string cleaning on "country" semantic types (doesn't handle accurately formatted but invalid codes)
- Indicate on the map viz settings that there are some invalid values in the data set (valuable even if it doesn't indicate which ones)
- Introduce a custom expression that would allow users to validate country codes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the map visualization handling for country semantic types and review how invalid or whitespace-padded country codes are treated. The issue needs a decision among the proposed approaches before completion can be defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
data-visualization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.