Bring the fingerprint-based unit selection logic from typescript into metabase.lib.drill-thru.summarize-column-by-time
- Dominant language
- Clojure
- Stars
- 49.3k
- Forks
- 6.8k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 653
Description
Bring the fingerprint-based unit selection logic from https://github.com/metabase/metabase/blob/0624d8d0933f577cc70c03948f4b57f73fe13ada/frontend/src/metabase-lib/metadata/Field.ts#L397
into this drill. Currently it always chooses the default date unit of months.
The TODO is in the test file `metabase.lib.drill-thru.summarize-column-by-time-test`
Contributor guide
Research direction
Compare the fingerprint-based unit selection logic in frontend/src/metabase-lib/metadata/Field.ts at the referenced commit with the TODO in metabase.lib.drill-thru.summarize-column-by-time-test. Trace the summarize-column-by-time drill implementation, then update the behavior so the selected date unit follows the field fingerprint instead of always defaulting to months, and verify it with the named test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure, typescript
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100