metabase / metabase/metabase

Use our execute-sql! fn in metabase.test.data.sql-jdbc.load-data instead of jdbc/execute

Open
#39,375 0 comments 0 reactions 0 assignees View on GitHub
.Backend Type:Tech Debt
Dominant language
Clojure
Stars
49.3k
Forks
6.8k
Avg merge
1d 13h
Merged PRs (30d)
653

Description

Inside the `do-insert` method for `:sql-jdbc/test-extensions` we use jdbc's execute function but we can instead use our own execute-sql! implementation.

Contributor guide

Open the contributing guide

Research direction

Start in the do-insert method for :sql-jdbc/test-extensions in metabase.test.data.sql-jdbc.load-data. Compare the current jdbc/execute call with the repository's execute-sql! implementation, then verify that the method uses execute-sql! and that the existing SQL-JDBC test data loading behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
databases
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.