Parameter.{id, target, value, name} should not be optional
Open
.Backend
.Team/QueryingPlatform
Type:Tech Debt
- Dominant language
- Clojure
- Stars
- 49.3k
- Forks
- 6.8k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 653
Description
```
src/metabase/mbql/schema.cljc:1631: ;; TODO -- these definitely SHOULD NOT be optional but a ton of tests aren't passing them in like they should be.
```
Contributor guide
Research direction
Open src/metabase/mbql/schema.cljc at line 1631 and inspect the Parameter schema and the tests referenced by its TODO. Make the id, target, value, and name fields non-optional, then run the affected tests and confirm they pass without relying on omitted fields.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100