metabase / metabase/metabase

Don't use search endpoint to check for existence of models

Open
#38,557 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

.Team/AdminWebapp Administration/Settings
Dominant language
Clojure
Stars
49.3k
Forks
6.8k
Avg merge
1d 13h
Merged PRs (30d)
653

Description

[discussion](https://metaboat.slack.com/archives/C064EB1UE5P/p1707405431922619)

On initial page load, we fire off a bunch of API requests, the single slowest of which is to the search endpoint (`/api/search?models=dataset&limit=1`) for the sole purpose of figuring out whether the instance has any models (we need to know this because we show different UI if you don’t have any models)

This feels pretty hacky, and I’m also pretty sure it’s a pretty heavy db operation

```
2024-02-08 15:10:51,644 DEBUG middleware.log :: GET /api/search 200 223.4 ms (5 DB calls) App DB connections: 1/10 Jetty threads: 5/50 (5 idle, 0 queued) (69 total active threads) Queries in flight: 0 (0 queued)
```

What if we moved this somewhere else, maybe something like has_models from /api/session/properties ? Would it make sense to persist this property instead of having every user run a big search query on every page load?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the initial page-load request to /api/search?models=dataset&limit=1 and the /api/session/properties entry point. Determine how the UI learns whether models exist, compare the database cost of the current search request with an alternative property, and verify that the resulting page-load behavior and empty-models UI remain correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
api, backend, performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.