metabase / metabase/metabase

We're showing the upload icon when the feature is disabled

Open
#36,799 4 comments 0 reactions 0 assignees View on GitHub
Organization/Uploads Type:New Feature
Dominant language
Clojure
Stars
49.3k
Forks
6.8k
Avg merge
1d 13h
Merged PRs (30d)
653

Description

### Describe the bug

A customer just told us that the icon is there when the feature is disabled. We shouldn't show the icon in that case
![image](https://github.com/metabase/metabase/assets/1711649/65653b02-ce60-46eb-b95e-39b077142526)

### To Reproduce

Just go into a collection with upload csv's disabled

### Expected behavior

we shouldn't show the icon

### Logs

_No response_

### Information about your Metabase installation

```JSON
v47.x
```

### Severity

P3

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue by opening a collection with CSV uploads disabled, then trace the collection UI and upload control responsible for the icon. Done means the upload icon is absent when the feature is disabled while remaining available when uploads are enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.