metabase / metabase/metabase

Add "Don't bin" option to TimeGroupingPopover

Open
#35,546 0 comments 1 reaction 0 assignees View on GitHub
.Frontend .Team/QueryingPlatform Querying/GUI Type:New Feature
Dominant language
Clojure
Stars
49.3k
Forks
6.8k
Avg merge
1d 13h
Merged PRs (30d)
653

Description

**Context**

`TimeGroupingPopover` after migration to MLv2 should have "Don't bin" option

- related issue: https://github.com/metabase/metabase/issues/19684

Enable disabled test "should render time series binning options correctly" https://github.com/metabase/metabase/blob/master/e2e/test/scenarios/binning/binning-options.cy.spec.js#L194

image

Contributor guide

Open the contributing guide

Research direction

Start with the TimeGroupingPopover implementation and the disabled test in e2e/test/scenarios/binning/binning-options.cy.spec.js around line 194. Trace the MLv2 time-grouping options, add the requested "Don't bin" choice, and enable the test once it confirms the expected options render.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
frontend, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.