Date filter picker doesn't take column's temporal unit in mind
Nobody has claimed this yet.
- Dominant language
- Clojure
- Stars
- 49.3k
- Forks
- 6.8k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 653
Description
Describe the bug
We should take datetime column's temporal unit in mind when filtering. Most date picker options don't make sense (and don't work) when trying to apply them to columns with buckets like "Year" or "X of Year".
To Reproduce
Year
- New > Question > Raw Data > Sample Database > Orders
- Summarize: Count by Created At: Year
- Add a filter for "Created At: Year"
- Most of the filter options don't make sense (e.g. Today or Yesterday)
Month of Year
- New > Question > Raw Data > Sample Database > Orders
- Summarize: Count by "Created At: Month of Year" (do not confuse with "Created At: Month")
- Add a filter for "Created At: Month"
- Again, most of the filter options don't make sense since "Created At: Month of Year" is rather a Category column now
Information about your Metabase installation
master
Severity
P3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue through New > Question > Raw Data > Sample Database > Orders, using the Created At Year and Month of Year summaries described above. Inspect the date filter picker behavior for these temporal units; done means irrelevant options such as Today and Yesterday are not offered or do not produce invalid filters, with the existing reproduction cases covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- data-visualization, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100