Have NativeQueryEditor use react-ace
- Dominant language
- Clojure
- Stars
- 49.3k
- Forks
- 6.8k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 653
Description
Our `NativeQueryEditor` currently uses a global, vanilla-js implementation of Ace.
Ace is a code editor to be embedded in webpages.
There is a now a React wrapper for ace, which should simplify implementation in our codebase.
## Immediate Goal
Simplify implementation of `NativeQueryEditor`
## Secondary Goals
1. Evaluate feasibility of using react-ace for the custom expression editor.
2. Abstract the a purer editing component that can be reused for native queries, custom expressions and other uses.
Contributor guide
Research direction
The issue names NativeQueryEditor as the entry point; start by locating its current global vanilla-JS Ace integration and comparing it with react-ace. Evaluate the custom expression editor as a second use case, and treat the reuse goal as complete only when the stated feasibility and abstraction questions have clear outcomes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100