metabase / metabase/macaw

Support quoted quotion marks within identifiers

Open
#50 0 comments 0 reactions 0 assignees View on GitHub
.Team/BackendComponents bug good first issue
Dominant language
Clojure
Stars
23
Forks
4
PR merge metrics
No merged PRs in 30d

Description

In SQL you can include the quote character within an identifier name by repeating it, e.g.

```sql
`schemer`.`the-table`.`doug``s mug`
```

```clojure
{:schema "schemer"
:table "the-table"
:column "doug`s mug"}
```

Metabase solves this with a slightly more complex [quote stripper](https://github.com/metabase/metabase/blob/19a756e6adee2985ac373ea39e210d1bf78af084/src/metabase/native_query_analyzer.clj#L57-L63) which we should be able to simply pilfer.

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the identifier handling with Metabase's native_query_analyzer.clj quote stripper at the linked lines, then trace the corresponding parsing path in Macaw. Support doubled quote characters inside quoted identifiers, and verify that the example preserves `doug`s mug` as the column name.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, sql
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.