meta-pytorch / meta-pytorch/torchcodec

Add C++ linting

Open
#840 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.2k
Forks
125
Avg merge
22h 47m
Merged PRs (30d)
54

Description

Right now, we only use clang for formatting our C++ code:
https://github.com/pytorch/torchcodec/blob/05a6ff59baf7bf1ab7e44ca79b923c2a4474ca96/.pre-commit-config.yaml#L31-L37

We should also do some actual linting with clang as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced .pre-commit-config.yaml lines 31–37 to see how clang currently formats the C++ code. Determine the appropriate clang linting configuration for this repository, then verify that the pre-commit setup performs linting as well as formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.