meta-pytorch / meta-pytorch/torchcodec
Add test video with missing number of frames and duration
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 125
- Avg merge
- 22h 47m
- Merged PRs (30d)
- 54
Description
PR #708 relaxed the requirement at the C++ level that the number of frames and the duration of the video or audio file must be present. We are doing this in eventual support of live streaming (see #695). The tests pass, and we checked that when we hack the C++ code to remove obtaining the values, we don't run into any segfaults. But, we don't have any tests that ensure the correct behavior with the values missing.
We should:
- Check in a small test video that has missing metadata for number of frames and duration.
- Use it for some of our ops tests - in particular, range queries in both indices and time. Tests that use the Python
VideoDeocderwill always fail because we assert the presence of these values at the Python level.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #708 and the existing ops tests that cover range queries by index and time. Add the small video fixture with missing frame-count and duration metadata, use it in those ops tests, and confirm the Python VideoDecoder tests remain excluded because they require these values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- audio-video-rtc, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100