meta-pytorch / meta-pytorch/torchcodec
Cleaning up uses of `std::string` vs `std::string_view`
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 125
- Avg merge
- 22h 47m
- Merged PRs (30d)
- 54
Description
We've been using both inconsistently. We should have a principled reason to use one vs the other. Note that we migrated a bunch of previous uses of std::string_view to std::string since the torch stable ABI requires it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Begin by locating the existing std::string and std::string_view uses, then review the torch stable ABI constraint and establish a consistent rule; done means the relevant uses follow a documented principle without violating ABI requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100