meta-pytorch / meta-pytorch/data
Update `ProtocolServer`'s exceptions to be more specific
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.3k
- Forks
- 179
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 2
Description
Within ProtocolServer inside dataloader2/communication/protocol.py, the exceptions being raised inside are generic Exception. Ideally, we should change the exceptions to be more specific, such that they can be handled easily elsewhere.
cc: @ejguan
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read dataloader2/communication/protocol.py and inspect the exception sites inside ProtocolServer. Determine the specific exception categories callers need to handle, then verify that each generic Exception raised there has an appropriate specific type without changing existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100