meta-pytorch / meta-pytorch/data

Hide symbol from openssl for TorchData releases

Open
#972 1 comment 0 reactions 1 assignee View on GitHub

@ejguan is already working on this.

Since Jan 27, 2023.

Better Engineering
Dominant language
Python
Stars
1.3k
Forks
179
Avg merge
6d 1h
Merged PRs (30d)
2

Description

🐛 Describe the bug

For all torchdata wheels, in order to provide the integration of AWSSDK, we statically linked OpenSSL to _torchdata.so, we should prevent any symbol from OpenSSL exposed by _torchdata.so. (Just add -fvisibility-hidden when build)
This was caused by stocking *.a files

Versions

main

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.