meta-pytorch / meta-pytorch/data
Broken tests for pickling circular reference DataPipe with dill
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.3k
- Forks
- 179
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 2
Description
🐛 Describe the bug
During the work to fixing the problem with unhashable DataPipe in https://github.com/pytorch/pytorch/pull/80509, I find this test is broken:
https://github.com/pytorch/pytorch/blob/e266bea79395399d60bd3c684545f69ae6900236/test/test_datapipe.py#L2307-L2349
The failure is: TypeError: cannot pickle 'PyCapsule' object
I tried to remove all the DataPipe reference from the CustomDataPipe and LambdaIterDataPipe, the Error still persisted. I am not sure what would be the root cause.
I will disable the test in my PR but we need to investigate the culprit.
Versions
master branch on PT
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the circular-reference DataPipe test in test/test_datapipe.py around lines 2307-2349 and reproduce its dill failure, TypeError: cannot pickle 'PyCapsule' object. Trace the objects involved in the test and determine the source of the unpicklable PyCapsule. Done means the culprit is documented and the test passes without simply disabling it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100