meta-pytorch / meta-pytorch/data

Caching will not unblock pipes if there is a filter between `on_disk_cache` and `end_caching`

Open
#434 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.3k
Forks
179
Avg merge
6d 1h
Merged PRs (30d)
2

Description

🐛 Describe the bug

See https://github.com/pytorch/text/issues/1735
Filtering of untar results leads to empty datapipe and block readers. Looks like we need to lint and probably work around this situation in cache too.

Versions

Master

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the on_disk_cache and end_caching behavior, then consult the linked pytorch/text issue 1735 and reproduce the filtered untar case. Trace how an empty datapipe blocks readers and identify the lint or cache workaround needed. Done means filtered results no longer leave readers blocked when caching is used.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.