meta-pytorch / meta-pytorch/data
Default constructing ShardingRoundRobinDispatcher results in exception
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.3k
- Forks
- 179
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 2
Description
🐛 Describe the bug
dp = dp.sharding_round_robin_dispatch()
results in
def __init__(self, source_datapipe: IterDataPipe, sharding_group_filter: Optional[SHARDING_PRIORITIES] = None):
self.source_datapipe = source_datapipe
if sharding_group_filter != SHARDING_PRIORITIES.MULTIPROCESSING:
> raise NotImplementedError(
"`sharding_round_robin_dispatch` currently only supports `SHARDING_PRIORITIES.MULTIPROCESSING`."
"Please open issue on github for your feature request."
)
E NotImplementedError: `sharding_round_robin_dispatch` currently only supports `SHARDING_PRIORITIES.MULTIPROCESSING`.Please open issue on github for your feature request.
Versions
e78ab6c9ec94f05f0a350ced7fe571f6863c20ec
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the sharding_round_robin_dispatch entry point and the ShardingRoundRobinDispatcher constructor; reproduce the default call shown in the issue. Trace how the optional sharding_group_filter is handled and verify that default construction no longer raises, using the relevant existing test coverage if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data, distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100