meta-pytorch / meta-pytorch/data
Replace portalocker with filelock to further reduce dependency
Open
Nobody has claimed this yet.
Better Engineering
- Dominant language
- Python
- Stars
- 1.3k
- Forks
- 179
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 2
Description
🚀 The feature
filelock module is added as a dependency for PyTorch when dynamo is introduced.
https://github.com/pytorch/pytorch/blob/a0d1dbc4466121f7aa0fa3754c5fbfe679c70c8e/requirements.txt#LL13-L13C9
We can re-use filelock module to do all file lock rather than portalocker.
Motivation, pitch
Reduce redundant dependency
Alternatives
No response
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the PyTorch requirements.txt entry linked in the issue, then search the repository for portalocker usage and existing file-locking entry points. Replace the file-locking dependency consistently and confirm that portalocker is no longer required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100