mesonbuild / mesonbuild/wrapdb
icu: seems to link with stubdata
- Dominant language
- Meson
- Stars
- 118
- Forks
- 298
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 24
Description
https://github.com/mesonbuild/wrapdb/blob/master/subprojects/packagefiles/icu/source/common/meson.build#L19
common_lib links with stubdata
```
common_lib = library(
#…
link_with: stubdata_lib,
#…
)
```
which is fine for build, but the dependency ought to link against `icudata_dep` from the source/data/meson.build. Instead, `icuuc_dep` links with the same `common_lib`.
```
icuuc_dep = declare_dependency(
link_with: common_lib,
compile_args: usage_args,
include_directories: incdir,
dependencies: dl_dep,
)
```
Not sure if this is a regression or not. I see it in the 'current' wrap
```
source_url = https://github.com/unicode-org/icu/releases/download/release-77-1/icu4c-77_1-src.tgz
source_filename = icu4c-77_1-src.tgz
source_hash = 588e431f77327c39031ffbb8843c0e3bc122c211374485fa87dc5f3faff24061
patch_filename = icu_77.1-1_patch.zip
patch_url = https://wrapdb.mesonbuild.com/v2/icu_77.1-1/get_patch
patch_hash = e74d6061fbb6c72f30fc8f755ed7a7780d8a35551630c71f4677a8e2b6a34547
source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/icu_77.1-1/icu4c-77_1-src.tgz
wrapdb_version = 77.1-1
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by comparing subprojects/packagefiles/icu/source/common/meson.build with source/data/meson.build, focusing on common_lib, stubdata_lib, icudata_dep, and icuuc_dep. Verify the intended dependency relationship and build the ICU wrap; done means the dependency uses the appropriate data dependency without breaking the current ICU build.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100