mesonbuild / mesonbuild/wrapdb

gRPC meson.build references `absl_crc32c` instead of `absl_crc` defined in wrap

Open
#1,323 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Meson
Stars
118
Forks
298
Avg merge
2d 2h
Merged PRs (30d)
24

Description

In grpc/meson.build@27, `absl_crc32c` is defined as a dependency:
https://github.com/mesonbuild/wrapdb/blob/8a706c7a03c69212310381add904ea7b382e4c72/subprojects/packagefiles/grpc/meson.build#L27

However, if you include absl-cpp via Meson wrap, that dependency is defined as `absl_crc`:
https://github.com/mesonbuild/wrapdb/blob/8a706c7a03c69212310381add904ea7b382e4c72/subprojects/abseil-cpp.wrap#L15

This results in the following error:
```log
Executing subproject grpc

grpc| Project name: gRPC
grpc| Project version: 1.59.1
grpc| C compiler for the host machine: cc (gcc 13.2.0 "cc (Rev3, Built by MSYS2 project) 13.2.0")
grpc| C linker for the host machine: cc ld.bfd 2.41
grpc| C++ compiler for the host machine: c++ (gcc 13.1.0 "c++ (Rev7, Built by MSYS2 project) 13.1.0")
grpc| C++ linker for the host machine: c++ ld.bfd 2.40
grpc| Dependency absl_algorithm_container from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_any_invocable from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_base from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_bind_front from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_cleanup from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_cord from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Dependency absl_core_headers from subproject subprojects/abseil-cpp-20230802.0 found: YES 20230802.0
grpc| Run-time dependency absl_crc32c found: NO (tried pkgconfig)

subprojects\grpc-1.59.1\meson.build:27:18: ERROR: Dependency "absl_crc32c" not found, tried pkgconfig
```

Adjusting the dependency name in either location resolves this, but I imagine it's best to adjust the grpc meson.build file, which appears to be autogenerated by a script that is not yet committed to git.

Tagging @klokik for awareness as I see they've been working on grpc wrap support (huge thanks)!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with grpc/meson.build at line 27 and compare its absl_crc32c dependency name with absl_crc at line 15 of subprojects/abseil-cpp.wrap. Investigate the uncommitted script that generates the gRPC Meson file before changing the generated output. Done means the wrap uses the dependency name defined by abseil-cpp and the reported Meson configuration error no longer occurs.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.