mesonbuild / mesonbuild/meson

meson dist doesn't notice a dirty meson.build

Open
#9,563 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

dist
Dominant language
Python
Stars
6.6k
Forks
1.9k
Avg merge
2d 6h
Merged PRs (30d)
33

Description

Describe the bug

So basically, I just updated my working copy to a new revision where the top level meson.build has been changed to specify the new release version. If i run meson dist in a previously configured build directory, meson will not notice that the top level meson.build has changed and proceed generate a tarball with the correct contents, but name the file after the old version that the build directory was configured for.

If I run ninja reconfigure and then meson dist the tarball is named as expected.

To Reproduce

I can provide a toy example if necessary, but this seems pretty straight forward.

Expected behavior

I expected that meson would see that the top level meson.build had been modified and run a configuration before proceeding to run the dist target.

system parameters

  • Is this a cross build or just a plain native build (for the same computer)?: native
  • what operating system (e.g. MacOS Catalina, Windows 10, CentOS 8.0, Ubuntu 18.04, etc.): Debian unstable+experimental
  • what Python version are you using e.g. 3.8.0: 3.9.7
  • what meson --version: 0.60.1
  • what ninja --version if it's a Ninja build: 1.10.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with a previously configured build directory, then change the top-level meson.build version and run meson dist without ninja reconfigure. Compare that result with running ninja reconfigure first; done means meson dist detects the changed build definition and names the tarball using the new version.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.