[CI] Build and Release Workflow Docker Missing Dependencies
- Dominant language
- Go
- Stars
- 90
- Forks
- 96
- PR merge metrics
- No merged PRs in 30d
Description
#### Current Behavior
**Missing Docker Dependency in [`build-and-release.yml`](https://github.com/meshery/meshsync/blob/master/.github/workflows/build-and-release.yml)**
Currently, both jobs run independently and in parallel. The `docker` job doesn't wait for the `build` job to complete.
**Risk**
- When the `build` jobs fail, the `docker` job still start and run.
- The Docker build process inside the Docker image might fail if the binary wasn't properly built.
- This creates a broken Docker image being pushed to the registry
#### Desired Behavior
Create explicit dependency telling github action, don't start the `docker` until `build` job succeed.
#### Implementation
Add `need` keyword which tells github action to create job dependency of `docker` job.
Contributor guide
Assessment
This issue has not been assessed yet.