meshery / meshery/meshkit

Allow the configuration of distributed tracing to be disabled

Open
#894 9 comments 0 reactions 1 assignee Claimed by @iamgoeldhruv View on GitHub
area/devops help wanted kind/enhancement
Dominant language
Go
Stars
223
Forks
225
Avg merge
7d 1h
Merged PRs (30d)
1

Description

### Current Behavior
Currently, while running Meshery Server, I see the following debug logs:

```
14:20:07 traces export: exporter export timeout: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:4317: connect: connection refused"
```

I have not defined a trace collector in my local deployment.

### Desired Behavior
I would like to be able to disable tracing in deployments without a defined collector target. These logs are unnecessary noise, when no collector is present.

### Implementation

1. Both github.com/meshery/meshkit **AND** github.com/meshery/meshery will need to be enhanced with this configurable deployment option.
2. Support an environment variable for Meshery deployments.
3. Ensure that this deployment option is exposed in Meshery's Helm chart values.yaml, too.

### Acceptance Tests

- [ ] 1. Unless, trace collector target is configured, don't attempt to connect to collector.
- [ ] 2. The appropriate installation / deployment pages in Meshery Docs are updated.

---
### Contributor [Guides](https://docs.meshery.io/project/contributing) and [Handbook](https://meshery.io/community#handbook)
- 🛠 [Meshery Build & Release Strategy](https://docs.meshery.io/project/contributing/build-and-release)
- 📚 [Instructions for contributing to documentation](https://github.com/meshery/meshery/blob/master/CONTRIBUTING.md#documentation-contribution-flow)
- Meshery documentation [site](https://docs.meshery.io/) and [source](https://github.com/meshery/meshery/tree/master/docs)
- 🎨 Wireframes and designs for Meshery UI in [Figma](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI)
- 🙋🏾🙋🏼 Questions: [Discussion Forum](http://discuss.meshery.io) and [Community Slack](https://slack.meshery.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.