mercurius-js / mercurius-js/auth
Auth directive on Union type ignores the applyPolicy function
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 82
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Given this schema:
directive @auth(
role: String
) on OBJECT
type Query {
searchData: Grid
}
union Grid = AdminGrid | ModeratorGrid | UserGrid
type AdminGrid @auth(role: "admin") {
totalRevenue: Float
}
type ModeratorGrid @auth(role: "moderator") {
banHammer: Boolean
}
type UserGrid @auth(role: "user") {
basicColumn: String
}
and this plugin setup:
app.register(require('mercurius-auth'), {
authContext (context) {
// you can validate the headers here
return {
identity: context.reply.request.headers['x-user-type']
}
},
async applyPolicy (policy, parent, args, context, info) {
const role = policy.arguments[0].value.value
app.log.info('Applying policy %s on user %s', role, context.auth.identity)
// we compare the schema role directive with the user role
return context.auth.identity === role
},
authDirective: 'auth'
})
The applyPolicy function is never executed.
If I change the schema to:
type Query {
- searchData: Grid
+ searchData: AdminGrid
}
The function is executed instead.
Here a complete code example + test (skipped) https://github.com/Eomm/fastify-discord-bot-demo/pull/30/commits/7ec5f23bdba2458f0f7027c95b32175c01d3a7fc
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked reproduction and skipped test, then trace how auth directives are handled when a field returns a union. Confirm the behavior for the provided schema and ensure the applyPolicy function is invoked for the applicable union member directives, with the test passing for both union and concrete return types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- api, authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100