meliorence / meliorence/react-native-snap-carousel
+1
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
+1
open files
./node_modules/react-native-snap-carousel/src/carousel/Carousel.js
./node_modules/react-native-snap-carousel/src/Pagination/Pagination.js
./node_modules/react-native-snap-carousel/src/Pagination/PaginationDot.js
./node_modules/react-native-snap-carousel/src/ParallaxImage/ParallaxImage.js
edit
import { ... ,ViewPropTypes } from 'react-native';
to
import { ... } from 'react-native';
import {ViewPropTypes} from 'deprecated-react-native-prop-types';
- 05.17 Edit
edit 1 file => 4 files
It Working!
can't see warning anymore.
RN 68.1+
https://github.com/facebook/react-native/issues/33557
Originally posted by @RyuWoong in https://github.com/meliorence/react-native-snap-carousel/issues/923#issuecomment-1123267641
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the four listed files under node_modules/react-native-snap-carousel/src: Carousel.js, Pagination.js, PaginationDot.js, and ParallaxImage.js. Inspect their React Native imports and verify the reported ViewPropTypes warning on React Native 68.1+. Done means the affected imports no longer produce the warning, with the change applied consistently across all four files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100