meliorence / meliorence/react-native-snap-carousel
Last item does not scroll for vertical stack
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
Is this a bug report, a feature request, or a question?
Bug report
Have you followed the required steps before opening a bug report?
- I have read the guidelines regarding bug report.
- I have reviewed the documentation in its entirety, including the dedicated documentations 📚.
- I have searched for existing issues and made sure that the problem hasn't already been reported.
- I am using the latest plugin version.
- I am following the issue template closely in order to produce a useful bug report.
Have you made sure that it wasn't a React Native bug?
As far as I can ascertain this is not a react native bug.
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
It definitely existing in iOS. Android has a different issue for rendering a vertical stack, I might report that separately if I can't find a workaround.
iOS version - deployment target 9.0
Is the bug reproductible in a production environment (not a debug one)?
Yes
Environment
Environment:
React: 16.7.0
React native: 0.57.8
react-native-snap-carousel: I've tried both 3.7.5 and master
Target Platform:
Android - N/A
iOS - 9.0 deployment target
Expected Behavior
When I reach the last item in my stack I expected I would be able to swipe back up to return to my previous item.
Actual Behavior
When I react the last item in my stack I an unable to swipe back up to my previous item unless I swipe at the very edges. This is somewhat sporadic, sometimes if you wait a second or two it will work.
Reproducible Demo
https://snack.expo.io/@riglar/surprised-strawberries
Steps to Reproduce
- Open up snack link
- Drag each orange square upwards until you hit the last (third) orange square
- Drag downwards in the middle of the orange square
- You see a lack of response to your drag.
- Now try dragging down on the very sides of the screen or after waiting a few seconds.
- You should be able to get to respond to a drag.
Extra info
When using 3.7.5 with loop, stack and vertical on iOS I believe this same issue appears on every slide, not just the last one. I have a screencast of this which I can share if you think it relevant.
Thank you
Thanks for making a great library, folks. I'm happy to contribute to a PR fix if you can guide me.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Expo Snack and reproduce the vertical stack behavior on iOS, then trace the carousel's vertical gesture and last-item handling. Compare the reported stack and loop configurations with the current repository behavior; done means the final item responds to a downward drag from the middle, not only at the screen edges or after waiting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100