meliorence / meliorence/react-native-snap-carousel
inactiveDotStyle doesnt load the style
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
Bug report
<Pagination
dotsLength={ENTRIES1.length}
activeDotIndex={this.state.slider1ActiveSlide}
containerStyle={styles.paginationContainer}
dotColor={"#7DC334"}
dotStyle={{ width: 8, height: 8, borderRadius: 4 }}
inactiveDotColor={"#C3EFAD"}
inactiveDotStyle={{ width: 8, height: 8, borderRadius: 4 }}
carouselRef={this._slider1Ref}
tappableDots={!!this._slider1Ref}
/>
inactiveDotStyle does not work properly. See the result:
Environment:
React: 16.0.0-beta.5
React native: 0.49.2
react-native-snap-carousel: 3.3.4
Target Platform:
Android (6.0)
iOS (10.3)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Pagination usage shown in the report and trace how inactiveDotStyle is handled in react-native-snap-carousel. Reproduce the example on Android or iOS, then verify that the inactive dots use the supplied width, height, and borderRadius while retaining inactiveDotColor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100