meliorence / meliorence/react-native-snap-carousel
Replace `shallowCompare` with `PureComponent`?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
It might be a good idea to replace shallowCompare with PureComponent, but will it work with dynamic data?
From React's doc:
If your objects contain complex data structures, it may produce false-negatives for deeper differences. Only extend PureComponent when you expect to have simple props and state.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the current shallowCompare usage and the related component props and state, then determine whether dynamic data makes PureComponent unsuitable. Done would require a clear decision, an agreed implementation scope, and validation of behavior for the relevant data shapes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100