meliorence / meliorence/react-native-image-gallery
Scrolling to correct position after rotating screen
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 717
- Forks
- 298
- PR merge metrics
- No merged PRs in 30d
Description
When having multiple images (more than 3) the scrolling to the correct position in the list after rotating the screen is not working correctly on android.
When i swipe to image with index 3, and then rotate the device from portrait to landscape, the scrolling to the postion of image with index 3 is not working, it ends up showing part of image on index 1 and part of image on index 2.
I created a PR where this will be fixed: https://github.com/archriss/react-native-image-gallery/pull/67
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Android rotation case described in the issue with more than three images, swiping to index 3 before rotating. Review pull request #67 for the proposed fix, then verify that rotation preserves the visible position at index 3 without showing parts of earlier images.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 20/100