meliorence / meliorence/react-native-image-gallery

initialPage does not work as expected again

Open
#61 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
717
Forks
298
PR merge metrics
No merged PRs in 30d

Description

The initialPage option does not work correctly on Android without using getItemLayout (which is true since https://github.com/archriss/react-native-image-gallery/pull/47). Since the list does not know the dimensions of the views, it cannot "offset" to page 4 initially. So you end up with that flickering.

I'm posting an issue but am forced to go using 2.1.4 instead of the last one.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing initialPage on Android without getItemLayout, using the page-4 case described in the issue. Compare the current behavior with pull requests #47 and #24; done means the gallery opens on the requested page without the reported flickering.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.