melange-community / melange-community/jsonkit
Should native use `Yojson.Safe`?
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 24
- Forks
- 7
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 5
Description
We had a recent case where melange-json would fail at runtime trying to parse ints that overflow ocaml representation.
@andreypopp I guess there were reasons why Yojson.Basic was chosen. What are the tradeoffs? Could melange-json move to use Yojson.Safe potentially?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating where melange-json selects and uses Yojson.Basic for native parsing, then reproduce the reported integer-overflow failure. Compare Yojson.Basic and Yojson.Safe behavior and compatibility, and consider the tradeoffs before defining whether a switch is appropriate; done means the decision and its consequences are documented or implemented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100