meilisearch / meilisearch/docs-scraper

with meilisearch:v1.15.2 the doc-scrapping is failing

Open
#478 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue
Dominant language
Python
Stars
346
Forks
52
PR merge metrics
No merged PRs in 30d

Description

Description
with meilisearch:v1.15.2 the doc-scrapping is failing with error:

Docs-Scraper: https://gitdocs.test.com/gitdocs/chaoseng/prod/test-report.html 72 records)
JSONDecodeError while adding documents for https://gitdocs.test.com/gitdocs/testone/prod/tech-acceptance.html: Expecting value: line 1 column 1 (char 0)
First record: {'anchor': None, 'content': 'Overview', 'type': 'content', 'tags': [], 'url': '/gitdocs/testone/prod/tech-acceptance.html', 'url_without_variables': '/gitdocs/testone/prod/tech-acceptance.html', 'page_status': None, 'url_without_anchor': '/gitdocs/testone/prod/tech-acceptance.html', 'no_variables': 'True', 'objectID': '25e3aae1a36a3bdf95e8087dde245beff6aba378', 'page_rank': 0, 'level': 0, 'position': 1, 'hierarchy_lvl0': 'Check-in Open Systems :: Architecture / Design Guidelines :: Technical Acceptance Checklist', 'hierarchy_lvl1': 'Page title', 'hierarchy_lvl2': None, 'hierarchy_lvl3': None, 'hierarchy_lvl4': None, 'hierarchy_lvl5': None, 'hierarchy_lvl6': None, 'hierarchy_radio_lvl0': None, 'hierarchy_radio_lvl1': None}

the above error comes when i put the debugger in add_records method in meillisearch_helper.py.

Current version we have is 0.12.12

everything works well in getmeili/meilisearch:v1.7.6 instance

Expected behavior
doc-scrapping should pass
Current behavior
it is giving error
Screenshots or Logs
If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

  • OS: [e.g. Debian GNU/Linux]
  • Meilisearch version: [e.g. v.1.15.2.]
  • docs-scraper version: [e.g v. 0.12.12]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in meillisearch_helper.py at the add_records method, where the reported JSONDecodeError occurs, and reproduce the docs-scraper run against Meilisearch v1.15.2 and v1.7.6. Trace the document-adding response and compare the behavior; done means documentation scraping passes with docs-scraper 0.12.12 on v1.15.2.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.