meilisearch / meilisearch/arroy
When building a tree or opening a writer, we don't check if the distances matches
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 311
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Currently, I can open a Writer with the wrong distance type, and it works, it shouldn’t.
IMO, in terms of API, it’s the new that should return an error if the metadata exists and doesn't contain the right distance type.
But at the same time, opening database should be super quick, so maybe it should be in the build.
We need to think about it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the tree-building and Writer entry points, especially new and build, and inspect how existing metadata records the distance type. Decide where the mismatch check belongs without slowing database opening. Done means opening or building with an incompatible distance type returns an error, with the API behavior documented and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- search
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100