medikoo / medikoo/movejs

Rename of module to path that shadows directory, breaks require

Open
#1 0 comments 0 reactions 1 assignee View on GitHub

@medikoo is already working on this.

Since Feb 1, 2016.

bug
Dominant language
JavaScript
Stars
3
Forks
1
No merged PRs in 30d

Description

Imagine we have directory structure:

foo/
foo/index.js
bar.js
some-module.js

Assume some-module.js contains require('./foo') call

If we rename bar.js to foo.js with movejs, it wouldn't update require in some-module.js, therefore module will get broken.
In such scenario require path within some-module.js should be changed to ./foo/

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.