medikoo / medikoo/dbjs-persistence

Consider support for promises in `search*` callback

Open
#9 0 comments 0 reactions 1 assignee View on GitHub

@medikoo is already working on this.

Since Jan 27, 2016.

Dominant language
JavaScript
Stars
1
Forks
1
No merged PRs in 30d

Description

They should postpone resolution of promise returned by search*.

Still question is, how we should handle early exit in such case. Waiting for eventual resolution of promises seems not great. Currently return of promise means return of truthy value so stop, and that should probably be maintained

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.