medikoo / medikoo/dbjs-persistence

Improve validation of `keyPath` when indexing

Open
#17 0 comments 0 reactions 1 assignee View on GitHub

@medikoo is already working on this.

Since Mar 8, 2016.

Dominant language
JavaScript
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

/cc @kamsi

It'll be great to introduce a validation of keyPath's as passed to indexes. Currenlty if there'a typo the indexing method will be silent.

Other idea is to setup indexes directly in definition, this will make keyPath's validation not needed.
Still by design persistence driver do not require dbjs instance (therefore model loaded), so probably best solution is to prepare some external utility that resolves indexes out of dbjs model

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.