setSearch() breaks previous url parameters
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 6.2k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
var myUri = new URI("https://google.com/a?b=c&d=e,f,g")
myUri.toString() // "https://google.com/a?b=c&d=e,f,g"
myUri.setSearch("new", "value")
myUri.toString() // "https://google.com/a?b=c&d=e%2Cf%2Cg&new=value"
Apparently during the buildQueryParameter functionality, we encode each parameter value thus causing ',' value to be encoded and not its original value
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at setSearch() and the buildQueryParameter functionality mentioned in the report, then reproduce the URI example with the existing parameters b=c and d=e,f,g. Done means adding the new parameter without changing the previous comma-containing value in toString().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100