medialize / medialize/URI.js

subdomain() doesn't parse localhost subdomains properly

Open
#375 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6.2k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

subdomain("http://my-subdomain.localhost") -> empty
domain("http://my-subdomain.localhost") -> my-subdomain.localhost

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported subdomain("http://my-subdomain.localhost") and domain("http://my-subdomain.localhost") calls, then trace the subdomain and domain parsing entry points. Done means subdomain() returns the localhost subdomain while domain() continues to return my-subdomain.localhost.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.