medialize / medialize/URI.js

Requiring a lower version of punycode

Open
#372 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6.2k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

Is it possible to lower the requirement for "punycode": "^2.1.0" to "punycode": "^1.4.1"?

The difference between punycode 1.4.1 and punycode 2.1.0 is just that the latter is written in ES6.

The current version supports recent versions of Node.js only. It provides a CommonJS module and an ES6 module. For the old version that offers the same functionality with broader support, including Rhino, Ringo, Narwhal, and web browsers, see v1.4.1.
-- punycode.js

When punycode 2.1.0 is used under IE11, it breaks with SCRIPT1002: Syntax error , because some ES6 constructs aren't supported.

I had this problem on the application I'm developing, and I fixed it by downgrading punycode to 1.4.1. Unfortunately your package doesn't allow a version lower than 2.1.0 and I'm afraid that it would break again if the punycode you are dependent on is used under IE11.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the package dependency declaration for the required punycode version and review the stated compatibility difference between versions 1.4.1 and 2.1.0. Verify the package's existing tests or browser checks with IE11 compatibility in mind; done means the dependency permits the older version without breaking URI.js.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.