uri.withinString fails on markdown links
Open
Nobody has claimed this yet.
Bug
- Dominant language
- JavaScript
- Stars
- 6.2k
- Forks
- 468
- PR merge metrics
- No merged PRs in 30d
Description
Doing
uri.withinString(msg.value.content.text, (link) => {
gives me:
dat://blog.tableflip.io/](dat://blog.tableflip.io/
for
[dat://blog.tableflip.io/](dat://blog.tableflip.io/) is a thing
But ] should not be a valid character in a URL according to rfc1738.txt
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the URI.withinString entry point and reproduce the reported markdown-link input, comparing the returned substring with the expected URL. Confirm that the closing bracket is excluded from the URL, and add or update coverage for this case if the relevant tests are located.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100