medialize / medialize/URI.js

jQuery Plugin - jQuery.expr[":"] is now jQuery.expr.pseudos

Open
#337 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6.2k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

While updating our site to jQuery v3.1.1 I am having issues with the jQuery plugin using jQuery.expr.

$.expr[':'].uri = uriSizzle;

I believe this should be changed to:

$.expr.pseudos.uri = uriSizzle;

Here's the explanation and recommended change: https://github.com/jquery/jquery-migrate/blob/master/warnings.md#jqmigrate-jqueryexpr-is-deprecated-use-jqueryexprpseudos

Didn't see anything regarding jQuery 3 support for URI.js, so I realize it may not be there yet, but thought I would at least submit this issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the plugin code containing $.expr[':'].uri = uriSizzle; and compare its behavior under jQuery 3.1.1. Update the selector registration to the documented jQuery 3 form, then verify that the :uri selector still works with the plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.