medialize / medialize/URI.js

relativeTo issue with empty folder

Open
#230 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Path Requires More Interest
Dominant language
JavaScript
Stars
6.2k
Forks
468
PR merge metrics
No merged PRs in 30d

Description

I have an issue with generating an relative url where the current browsers url contains an empty folder:

history.pushState(null,'test','/a//c/d') // browser path: example.com/a//c/d
var uri = new URI('http://example.com/a').relativeTo(new URI()) // uri = "../../a"
history.pushState(null,'test2',uri.toString()) // browser path: example.com/a/a

The problem is that normalizePath convert '/a//c/d' to '/a/c/d'. Maybe you can find a solution for me?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the provided history.pushState and URI.relativeTo example, then inspect normalizePath and the relativeTo path handling. Done means an empty folder in the browser path is handled without changing the resulting relative URL to the incorrect duplicated /a/a path.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.