mdx-editor / mdx-editor/editor

[BUG] Unfocusing the editor allows the user to create nested admonitions

Open
#469 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
3.7k
Forks
307
Avg merge
14h 22m
Merged PRs (30d)
5

Description

According to #428 it shouldn't be possible to create nested admonitions, however there is a UI bug that exposes the insert admonition toolbar button when the user unfocus the editor.

Kooha-2024-05-24-19-57-42

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by unfocusing the editor and observing the insert admonition toolbar button. Trace the toolbar behavior around editor focus and admonition nesting; done means unfocusing cannot expose an action that creates nested admonitions, while the existing non-nesting behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.