mdolab / mdolab/pyoptsparse

Set fail flag to True if `funcs` or `funcsSens` contain `nan` or `inf` values

Open
#110 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement stale
Dominant language
Python
Stars
270
Forks
123
Avg merge
1d 18h
Merged PRs (30d)
3

Description

Type of issue

What types of issue is it?
Select the appropriate type(s) that describe this issue

  • New feature (non-breaking change which adds functionality)

Description

Current behavior

There is no error checking for if funcs and funcsSens contain either nan or inf values.

Expected behavior

There should be error checking, probably in the _masterFunc2 call. The fail flag should be set if either dictionaries contain any values which are either nan or inf.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the _masterFunc2 call and inspect how funcs and funcsSens are validated and how the fail flag is set. Trace the existing tests for this path, then verify that either dictionary's nan or inf values set fail to True without changing valid inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.